When doing a retry, throw some randomness into the mix #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a pretty straightforward PR and I'll be moving forward with the merge to reduce code review churn. |
|
We can see that with this PR the retries are a little bit more spaced out between them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvement to the retry logic, especially useful for our parallel tests.
What this fixes:
This PR throws some randomness into the mix, waiting the specified
Retry-Afterspecified by the server, and adding between 0 and 5 seconds of additional wait, to avoid all retries being done in the same time.In the current behavior, we can see that several requests hit 429 at 12:34:17, and retried at 12:34:27.